Spark 4.0: Display write metrics on SQL UI #13253
Conversation
manuzhang
force-pushed
the
spark-sql-write-metrics
branch
from
4bc7385 to
bed0942
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
manuzhang
force-pushed
the
spark-sql-write-metrics
branch
from
bed0942 to
1290eac
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
manuzhang
force-pushed
the
spark-sql-write-metrics
branch
from
1290eac to
52bc928
Compare
|
I'm also looking for this feature! @manuzhang, if this is not easy to add UT, could you please leave some screenshots and queries to allow reviewers to verify this locally? |
|
@pan3793 Added a snapshot in the PR description. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
manuzhang
force-pushed
the
spark-sql-write-metrics
branch
from
52bc928 to
929c614
Compare
| return null; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: should this be
if (!metricsReport instanceof CommitReport) {
return null
}
return (CommitReport) metricsReport;
There was a problem hiding this comment.
Why do you think this is better?
There was a problem hiding this comment.
more readable (it is a style thing); hence tagged with nit
There was a problem hiding this comment.
I got it it's a style thing but not sure why what you suggests is better.
There was a problem hiding this comment.
if (!metricsReport instanceof CommitReport) {
return null
}
return (CommitReport) metricsReport;
looks less verbose to me
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
3 participants
Uh oh!
There was an error while loading. Please reload this page.