fix(puffin): add missing magic number validation for puffins#2416
Open
dentiny wants to merge 1 commit intoapache:mainfrom
Open
fix(puffin): add missing magic number validation for puffins#2416dentiny wants to merge 1 commit intoapache:mainfrom
dentiny wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
We have two functions to read puffin metadata:
readandread_with_prefetch. In theory these two functions should be similarly the same apart from IO-related logic, butread_with_prefetchseems to miss magic number validation:iceberg-rust/crates/iceberg/src/puffin/metadata.rs
Line 284 in 4f21e50
In terms of implementation, I thought about extracting validation+footer parse into a separate function, but the code is very simple here, don't think it necessary.
Are these changes tested?
Yes, the newly added regression test fails for the current codebase