feat(delete-vector): parse deletion-vector-v1 puffin blob - read support#2414
Open
Shekharrajak wants to merge 1 commit intoapache:mainfrom
Open
feat(delete-vector): parse deletion-vector-v1 puffin blob - read support#2414Shekharrajak wants to merge 1 commit intoapache:mainfrom
Shekharrajak wants to merge 1 commit intoapache:mainfrom
Conversation
Shekharrajak
force-pushed
the
feat/dv-blob-parser-2411
branch
from
d8d4048 to
7ce78ba
Compare
Shekharrajak
force-pushed
the
feat/dv-blob-parser-2411
branch
from
7ce78ba to
f625093
Compare
Shekharrajak
changed the title
Shekharrajak
commented
May 9, 2026
| } | ||
|
|
||
| #[allow(dead_code)] | ||
| pub fn deserialize_blob(blob_bytes: &[u8], expected_cardinality: Option<u64>) -> Result<Self> { |
Contributor
Author
There was a problem hiding this comment.
Read path deserialize_blob parses a binary blob (length + magic + roaring bitmap + CRC32) into a DeleteVector.
Shekharrajak
commented
May 9, 2026
|
|
||
| #[allow(dead_code)] | ||
| pub fn deserialize_blob(blob_bytes: &[u8], expected_cardinality: Option<u64>) -> Result<Self> { | ||
| if blob_bytes.len() < DV_MIN_BLOB_SIZE { |
Contributor
Author
There was a problem hiding this comment.
Minimum size check
Shekharrajak
commented
May 9, 2026
| } | ||
|
|
||
| // 2GB cap matches Java's signed-i32 length field. | ||
| if blob_bytes.len() > i32::MAX as usize { |
Contributor
Author
There was a problem hiding this comment.
2GB cap - Java's Integer.MAX_VALUE is 2,147,483,647 — exactly i32::MAX - similar to java implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #2411
What changes are included in this PR?
Are these changes tested?