fix(table): possible snapshot corruption #654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new snapshot being created
lamOrigin007
force-pushed
the
fix-fast-append-producer
branch
from
67dc6fc to
7937999
Compare
zeroshade
reviewed
Dec 22, 2025
|
|
||
| for _, m := range manifests { | ||
| if m.HasAddedFiles() || m.HasExistingFiles() || m.SnapshotID() == fa.base.snapshotID { | ||
| if _, ok := previousSnapshotList[m.SnapshotID()]; m.HasAddedFiles() || m.HasExistingFiles() || ok { |
Member
There was a problem hiding this comment.
I'm confused, if we're saying that the existing manifests can't contain the current snapshot_id shouldn't this use !ok?
Why are we searching the previous snapshot list? Couldn't we just remove this check entirely and just do if m.HasAddedFiles() || m.HasExistingFiles() { ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing manifest files cannot have the snapshotID of the new snapshot being created.