feat(catalog): add WithHeaders function #652
Open
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
force-pushed
the
with_headers
branch
from
d173ebd to
3660d0d
Compare
zeroshade
changed the title
zeroshade
requested changes
Dec 22, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Can you also add a test that expects the custom headers on the fetchAccessToken routes where it fetches credentials?
Contributor
Author
|
@zeroshade added the tests and addressed the comments, ptal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532
This adds support for sending custom headers for IRC requests.
I'm happy to add a
WithClientfunction as well (for sending a custom HTTP client), but it's unclear when the custom client would be used versus the options the user has sent.