feat(catalog/glue): add option to customize IO loader function #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
May 27, 2025
|
|
||
| type Option func(*options) | ||
|
|
||
| type FSLoaderFunction func(ctx context.Context, props map[string]string, location string) (io.IO, error) |
Member
There was a problem hiding this comment.
Rather than doing this, would it make more sense to set up a registry with the io.IO similar to the catalog registry we have? Where the scheme can be used to register specific handlers for file systems?
Contributor
Author
There was a problem hiding this comment.
@zeroshade thanks for the feedback. Maybe #455 looks like what you had in mind?
Contributor
Author
|
Closing this in favor of #455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to customize the function used to determine which
io.IOimplementation to load when constructing a Glue catalog.