fix: use secure random for UUID generation#602
Merged
wgtmac merged 1 commit intoapache:mainfrom Mar 25, 2026
Merged
Conversation
Replaced the non-cryptographically secure std::mt19937 with std::random_device for generating UUID v4 and v7. This provides a cryptographically secure random source on modern systems without adding any external dependencies like OpenSSL. Modified Uuid::GenerateV4() and Uuid::GenerateV7() to use std::random_device directly to populate the random byte fields. This prevents potential predictability issues with generated UUIDs. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
evindj
approved these changes
Mar 25, 2026
blackmwk
approved these changes
Mar 25, 2026
Member
Author
|
Thanks all for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the non-cryptographically secure std::mt19937 with std::random_device for generating UUID v4 and v7. This provides a cryptographically secure random source on modern systems.