feat: add support to read metadata columns #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support reading _file and _pos - support avro and parquet files
HuaHuaY
approved these changes
Jan 4, 2026
WZhuo
approved these changes
Jan 4, 2026
zhjwpku
approved these changes
Jan 4, 2026
| namespace iceberg::arrow { | ||
|
|
||
| /// \brief Context for populating metadata columns during reading. | ||
| struct MetadataColumnContext { |
Collaborator
There was a problem hiding this comment.
Does it make sense to move this structure to metadata_columns.h?
Member
Author
There was a problem hiding this comment.
I've thought about this but finally decided not to do this. The reason is that there are more metadata columns in that file and we just need only two of them.
Collaborator
There was a problem hiding this comment.
Make sense, thanks for the explanation.
liurenjie1024
approved these changes
Jan 4, 2026
Member
Author
|
Thanks all for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_fileand_pos