HIVE-29441: Avoid resolving dependency org.glassfish:javax.el #6297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturoczy
approved these changes
Feb 4, 2026
zabetak
reviewed
Feb 4, 2026
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
This annoying dependency keeps creeping in our build and remains unnoticed till the build breaks. Can we add an enforcer rule so that it does not come back ever again?
hbase-handler/pom.xml
Outdated
Comment on lines
200
to
205
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.glassfish.web</groupId> | ||
| <artifactId>javax.servlet.jsp</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
Member
There was a problem hiding this comment.
Can we refactor the exclusion in the dependency management section instead of putting it everywhere?
Contributor
Author
There was a problem hiding this comment.
It seems that it works, so I've updated the PR. Could you have another look, please?
Exclude org.glassfish.web:javax.servlet.jsp from hbase-testing-util
thomasrebele
force-pushed
the
tr/HIVE-29441
branch
from
0c9114e to
3bceb79
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by excluding org.glassfish.web:javax.servlet.jsp from hbase-testing-util (HIVE-29441)
What changes were proposed in this pull request?
Similar to HIVE-24809, exclude the dependency org.glassfish.web:javax.servlet.jsp from hbase-testing-util.
Why are the changes needed?
Without the patch, building fails on my machine with an exception
Caused by: The following artifacts could not be resolved: org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT (absent): Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT from/to jvnet-nexus-snapshots (https://maven.java.net/content/repositories/snapshots): status code: 402, reason phrase: Payment Required (402)Does this PR introduce any user-facing change?
No
How was this patch tested?
Building Hive locally with
mvn clean install -DskipTests -Pitests,dist -Denforcer.skip=true -T1C