Skip to content

HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinhyukify wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login #8002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,14 @@ public void testLoginWithUserKeytabAndPrincipal() throws Exception {
}

@Test
public void testAuthUtilLogin() throws Exception {
public void testAuthUtilLoginWithExistingLoginUser() throws Exception {
Copy link
Copy Markdown
Contributor Author

@jinhyukify jinhyukify Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this test to only cover the case where a Kerberos user is already logged in.

String clientKeytab = getClientKeytabForTesting();
String clientPrincipal = getClientPrincipalForTesting();
Configuration conf = getSecuredConfiguration();
conf.set(AuthUtil.HBASE_CLIENT_KEYTAB_FILE, clientKeytab);
conf.set(AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL, clientPrincipal);
UserGroupInformation.setConfiguration(conf);
UserGroupInformation.loginUserFromKeytab(clientPrincipal, clientKeytab);
Copy link
Copy Markdown
Member

@junegunn junegunn Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this issue has been bothering me for a while, and I can confirm this makes the test pass.

However, if we do this, we no longer test if AuthUtil.loginClient actually performs the login for the user. I think we could create a separate user principal, log in as that user, and then test whether ⁠AuthUtil.loginClient correctly logs in the original user and returns that user.


User user = AuthUtil.loginClient(conf);
assertTrue(user.isLoginFromKeytab());
Expand Down