Skip to content

HBASE-29871 During WAL write times out add DataNode address in. the exception message #7719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinireddy2020 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −6
Open

HBASE-29871 During WAL write times out add DataNode address in. the exception message #7719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3faaac0
HBASE-29871 During WAL write times out add DataNode address in. the e…
srinireddy2020 Feb 7, 2026
435757a
HBASE-29871 During WAL write times out add DataNode address in. the e…
srinireddy2020 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...syncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,8 @@ public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exc
if (evt instanceof IdleStateEvent) {
IdleStateEvent e = (IdleStateEvent) evt;
if (e.state() == READER_IDLE) {
failed(ctx.channel(),
() -> new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
failed(ctx.channel(), () -> new IOException("Timeout(" + timeoutMs
+ "ms) waiting for response from datanode " + ctx.channel().remoteAddress()));
} else if (e.state() == WRITER_IDLE) {
PacketHeader heartbeat = new PacketHeader(4, 0, HEART_BEAT_SEQNO, false, 0, false);
int len = heartbeat.getSerializedSize();
Expand Down
7 changes: 4 additions & 3 deletions .../src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ protected void channelRead0(ChannelHandlerContext ctx, BlockOpResponseProto resp
if (PipelineAck.isRestartOOBStatus(pipelineStatus)) {
throw new IOException("datanode " + dnInfo + " is restarting");
}
String logInfo = "ack with firstBadLink as " + resp.getFirstBadLink();
String logInfo =
"ack with firstBadLink as " + resp.getFirstBadLink() + " from datanode " + dnInfo;
if (resp.getStatus() != Status.SUCCESS) {
if (resp.getStatus() == Status.ERROR_ACCESS_TOKEN) {
throw new InvalidBlockTokenException("Got access token error" + ", status message "
Expand Down Expand Up @@ -378,8 +379,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) {
promise
.tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
promise.tryFailure(new IOException(
Copy link
Contributor

@vaijosh vaijosh Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinireddy2020
In other two places we are logging "channel.remoteAddress" in message and here dnInfo.toString.

Can't we keep it consistent?

Copy link
Contributor Author

@srinireddy2020 srinireddy2020 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the method parameter already having the DN details so no need to call channel.remoteAddress.

"Timeout(" + timeoutMs + "ms) waiting for response from datanode " + dnInfo));
} else {
super.userEventTriggered(ctx, evt);
}
Expand Down
3 changes: 2 additions & 1 deletion .../main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,8 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
@Override
public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) {
promise.tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
promise.tryFailure(new IOException("Timeout(" + timeoutMs
+ "ms) waiting for response from datanode " + ctx.channel().remoteAddress()));
} else {
super.userEventTriggered(ctx, evt);
}
Expand Down