HBASE-29787 Run static checks to a Github Action

.github/workflows/yetus-general-check.yml

@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yamllint disable rule:line-length
+---
+name: Yetus General Check
+
+"on":
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+permissions:
+  checks: write
+  contents: read
+  pull-requests: write
+  statuses: write
+
+jobs:
+  general-check:
+    runs-on: ubuntu-latest
+    timeout-minutes: 600
+
+    env:
+      YETUS_VERSION: '0.15.0'
+
+    steps:
+      - name: Checkout HBase
+        uses: actions/checkout@v4
+        with:
+          path: src
+          fetch-depth: 0
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v4
+        with:
+          java-version: '17'
+          distribution: 'temurin'
+
+      - name: Maven cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2
+          key: hbase-m2-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            hbase-m2-
+
+      - name: Download Yetus
+        run: |
+          mkdir -p yetus
+          cd yetus
+          bash "${{ github.workspace }}/src/dev-support/jenkins-scripts/cache-apache-project-artifact.sh" \
+            --keys 'https://downloads.apache.org/yetus/KEYS' \
+            --verify-tar-gz \
+            ./apache-yetus-${{ env.YETUS_VERSION }}-bin.tar.gz \
+            yetus/${{ env.YETUS_VERSION }}/apache-yetus-${{ env.YETUS_VERSION }}-bin.tar.gz
+          tar --strip-components=1 -xzf apache-yetus-${{ env.YETUS_VERSION }}-bin.tar.gz
+          rm apache-yetus-${{ env.YETUS_VERSION }}-bin.tar.gz
+
+      - name: Run Yetus Test Patch
+        env:
+          ARCHIVE_PATTERN_LIST: "TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump"
+          DOCKERFILE: "${{ github.workspace }}/src/dev-support/docker/Dockerfile"
+          GITHUB_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_USER: ${{ github.actor }}
+          PATCHDIR: "${{ github.workspace }}/output"
+          PLUGINS: "all,-javadoc,-jira,-shadedjars,-unit"
+          SET_JAVA_HOME: "/usr/lib/jvm/java-17"
+          SOURCEDIR: "${{ github.workspace }}/src"
+          TESTS_FILTER: "checkstyle,javac,javadoc,pylint,shellcheck,shelldocs,blanks,perlcritic,ruby-lint,rubocop"
+          YETUSDIR: "${{ github.workspace }}/yetus"
+          AUTHOR_IGNORE_LIST: "src/main/asciidoc/_chapters/developer.adoc"
+          BLANKS_EOL_IGNORE_FILE: "dev-support/blanks-eol-ignore.txt"
+          BLANKS_TABS_IGNORE_FILE: "dev-support/blanks-tabs-ignore.txt"
+          EXCLUDE_TESTS_URL: "https://ci-hbase.apache.org/job/HBase-Find-Flaky-Tests/job/${{ github.base_ref }}/lastSuccessfulBuild/artifact/output/excludes"
+          BUILD_THREAD: "4"
+          SUREFIRE_FIRST_PART_FORK_COUNT: "0.5C"
+          SUREFIRE_SECOND_PART_FORK_COUNT: "0.5C"
+          HADOOP_PROFILE: "3.0"
+          BRANCH_NAME: "${{ github.base_ref }}"
+        run: |
+          cd "${{ github.workspace }}"
+          bash src/dev-support/jenkins_precommit_github_yetus.sh
+
+      - name: Publish Test Results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: yetus-general-check-output
+          path: ${{ github.workspace }}/output
+          retention-days: 7

dev-support/jenkins_precommit_github_yetus.sh

@@ -31,7 +31,6 @@ declare -i missing_env=0
 declare -a required_envs=(
   # these ENV variables define the required API with Jenkinsfile_GitHub
   "ARCHIVE_PATTERN_LIST"
-  "BUILD_URL_ARTIFACTS"
   "DOCKERFILE"
   "GITHUB_PASSWORD"
   "GITHUB_USER"
@@ -53,6 +52,12 @@ for required_env in "${required_envs[@]}"; do
   fi
 done
 
+# BUILD_URL_ARTIFACTS is required for Jenkins but optional for GitHub Actions
+if [[ "${GITHUB_ACTIONS}" != "true" ]] && [[ -z "${BUILD_URL_ARTIFACTS}" ]]; then
+  echo "[ERROR] Required environment variable 'BUILD_URL_ARTIFACTS' is not set."
+  missing_env=${missing_env}+1
+fi
+
 if [ ${missing_env} -gt 0 ]; then
   echo "[ERROR] Please set the required environment variables before invoking. If this error is " \
        "on Jenkins, then please file a JIRA about the error."
@@ -103,7 +108,9 @@ YETUS_ARGS+=("--spotbugs-strict-precheck")
 # rsync these files back into the archive dir
 YETUS_ARGS+=("--archive-list=${ARCHIVE_PATTERN_LIST}")
 # URL for user-side presentation in reports and such to our artifacts
-YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}")
+if [[ -n "${BUILD_URL_ARTIFACTS}" ]]; then
+  YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}")
+fi
 # plugins to enable
 YETUS_ARGS+=("--plugins=${PLUGINS},-findbugs")
 # run in docker mode and specifically point to our

hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/ClientTests.java

@@ -1,25 +1,9 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 package org.apache.hadoop.hbase.testclassification;
 
 /**
  * Tag a test as related to the client. This tests the hbase-client package and all of the client
  * tests in hbase-server.
+ * @author ndimiduk
  * @see org.apache.hadoop.hbase.testclassification.ClientTests
  * @see org.apache.hadoop.hbase.testclassification.CoprocessorTests
  * @see org.apache.hadoop.hbase.testclassification.FilterTests
@@ -36,5 +20,5 @@
  * @see org.apache.hadoop.hbase.testclassification.VerySlowMapReduceTests
  */
 public interface ClientTests {
-  public static final String TAG = "org.apache.hadoop.hbase.testclassification.ClientTests";
+  public static final   String TAG = "org.apache.hadoop.hbase.testclassification.ClientTests";
 }