Update/robustify the release scripts for subpackages (apache-hamilton-*)#1613
Open
Dev-iL wants to merge 13 commits into
Open
Update/robustify the release scripts for subpackages (apache-hamilton-*)#1613Dev-iL wants to merge 13 commits into
Dev-iL wants to merge 13 commits into
Conversation
The UI wheel must include compiled frontend assets (hamilton_ui/build/). This directory is gitignored and only exists after npm run build. - apache_release_helper.py: automatically runs npm install + npm run build and copies output to hamilton_ui/build/ before flit build for the UI package - verify-sub-packages.md: documents manual frontend build steps - verify_ui.sh: notes that source tarball build is backend-only; functional tests use the pre-compiled wheel from SVN
So flit is not needed as a separate dep
…out shadowing venv packages Python puts '' (cwd) at the front of sys.path; when scripts run from the repo root, that resolves to the local hamilton checkout and shadows packages installed in the test venv (e.g. hamilton.contrib.version not found). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- apache-hamilton-sdk: 0.8.0 -> 0.9.0
- apache-hamilton-ui: 0.0.17 -> 0.0.18
- apache-hamilton-lsp: 0.1.0 -> 0.2.0
- apache-hamilton-contrib: 0.0.8 -> 0.0.9
- Update root pyproject.toml extras to point to apache-hamilton-{lsp,sdk,ui}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains QoL improvements and fixes to various issues encountered while verifying the
apache-hamilton-{sdk,ui,lsp,contrib}packages in the context of https://lists.apache.org/thread/d4fzmqq4jbsx5m3krdp1qbr0wh9j131s and related threads.Includes #1612
Changes
UI Package (
apache-hamilton-ui)README.mdfor theui/backendpackage, fixinglong_description/long_description_content_typewarnings duringflit buildnpm run buildand copies compiled frontend assets intohamilton_ui/build/before building the wheel, ensuring the UI package includes its frontend (from Add frontend build step to UI release process #1612)Release Helper (
scripts/apache_release_helper.py)--no-sign/-ns: skips GPG signing; implicitly also skips upload since unsigned artifacts must never be published--no-upload/-nu: skips git tagging and SVN upload while still signing; useful for rehearsing the full signing step without publishingapache_idis no longer required when--no-upload(or--no-sign) is setuvscript dependencies declared in the PEP 723 inline metadata block so the script can be run withuv runVerification Scripts (
scripts/verify-sub-packages/)cd /tmpbefore functional checks in all four verify scripts (verify_contrib.sh,verify_sdk.sh,verify_lsp.sh,verify_ui.sh): prevents Python's implicit''(cwd)sys.pathentry from resolving the local checkout instead of the venv-installed packages when the script is run from the repo rootverify_ui.sh: improved diagnostics when the UI health-check endpoint is unreachableuvx flitused in place of a separately installedflitacross all verify scriptsui/sdk/.pre-commit-config.yamlHow I tested this
After introducing these changes I could successfully run the verification shell scripts for all distributions as well as
uv run scripts/apache_release_helper.py --package {pkg} {ver} 0 -nsNotes
I had include the version bump commit so that
apache_release_helper.pyruns correctly (with the new versions). We might want to consider making the version mismatch non-fatal when building packages with no intention to upload them.Checklist