Remove implicit assumption about git from test_git_directory_exists#1544
Merged
skrawcz merged 1 commit intoapache:mainfrom Apr 7, 2026
Merged
Remove implicit assumption about git from test_git_directory_exists#1544skrawcz merged 1 commit intoapache:mainfrom
test_git_directory_exists#1544skrawcz merged 1 commit intoapache:mainfrom
Conversation
test_git_directory_exists
skrawcz
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing 1.90.0rc0 a test failed:
This is because the
test_git_directory_exists()integration-style test currently depends on the checkout being a real Git worktree. This PR updates the test to unit-testget_git_base_directory()by mockingsubprocess.run, which makes it stable underuv runtarball/sdist environments.How I tested this
Test was failing, now it passes.
Checklist