Conversation
|
@skrawcz , can you please review this and let me know if any changes are required |
skrawcz
left a comment
There was a problem hiding this comment.
In the right direction. Some changes please.
… changes for delim_whitespace
skrawcz
left a comment
There was a problem hiding this comment.
thanks for the changes -- just need to get CI to pass now.
|
Hi @skrawcz , any update on the latest changes |
|
@AvinashYerra you have a pre-commit error. Can you install the pre-commit hooks and run them please? That will help fix the issue. |
|
@AvinashYerra Pandas 3.0 has just been released. Can you please check that there are no new incompatibilities? |
|
@skrawcz , I ran pre-commit locally and hit failures due to example files which has a syntax issues such as |
This actually looks like a symlink that's meant to work on linux, and you're on windows so it isn't understood correctly. If this is the case, perhaps try running the tests via WSL. |
skrawcz
left a comment
There was a problem hiding this comment.
Looks good, but can't merge this. If you could undo the other file changes and remove that new file then this looks like it's in a good spot.


This PR fixes the #1417 to remove the deprecated pandas CSV reader args. Fixed by adding a variable for identifying the pandas version and updated the functions to add them into kwargs only the version is less than 2.0
Changes
How I tested this
Checklist