[#11352] fix(glue): improve error logging for Iceberg metadata loading#11359
Open
xxubai wants to merge 2 commits into
Open
[#11352] fix(glue): improve error logging for Iceberg metadata loading#11359xxubai wants to merge 2 commits into
xxubai wants to merge 2 commits into
Conversation
Code Coverage Report
Files
|
diqiu50
reviewed
Jun 3, 2026
| } | ||
|
|
||
| @Test | ||
| void testLoadTable_icebergMetadataLoadFailureKeepsGlueOpsContext() { |
Contributor
There was a problem hiding this comment.
The function name is no match the code style
Contributor
Author
There was a problem hiding this comment.
The other test functions use the same naming convention. But I update this unit test funtion name
|
|
||
| @Test | ||
| void testLoadTable_icebergMetadataLoadFailureKeepsGlueOpsContext() { | ||
| software.amazon.awssdk.services.glue.model.Table rawTable = |
Contributor
Author
There was a problem hiding this comment.
Already import Iceberg table class: import org.apache.iceberg.Table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the Glue catalog warning when loading Iceberg metadata fails.
The warning no longer says that partitioning and sort order information may be incomplete. Instead, it reports the Iceberg metadata load failure directly and keeps the original exception in the stacktrace, so missing
metadata.jsonfiles are easier to diagnose.This PR also adds a regression test to ensure that a table returned after Iceberg metadata loading fails still keeps its Glue operation context.
Why are the changes needed?
The previous warning was misleading when the real root cause was a missing Iceberg metadata file, for example an S3
NoSuchKeyExceptionformetadata/*.metadata.json. It made the issue look like a partition or sort-order compatibility problem.Fix: #11352
Does this PR introduce any user-facing change?
Yes. The Glue catalog warning message for Iceberg metadata loading failures is changed.
No API or configuration changes are introduced.
How was this patch tested?
./gradlew :catalogs:catalog-glue:test --tests org.apache.gravitino.catalog.glue.TestGlueCatalogOperationsForIceberg -PskipITs./gradlew :catalogs:catalog-glue:test -PskipITs