[#11335] web(ui): setting web v2 ui as default#11344
Open
LauraXia123 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Switches the default Gravitino Web UI from V1 to V2 by replacing the opt-in GRAVITINO_USE_WEB_V2 flag with an opt-out GRAVITINO_USE_WEB_V1 flag, and updates docs, env template, launch script, build, and CI accordingly.
Changes:
- Invert UI selection in
bin/gravitino.sh.templateandbuild.gradle.kts(deploy/embedded test paths) so V2 is preferred unlessGRAVITINO_USE_WEB_V1=true. - Update
gravitino-env.sh.template, README,docs/webui-v2.md,web-v2/web/README.md, and the V1 banner inLayout.jsto reflect the new flag and default. - Drop
GRAVITINO_USE_WEB_V2=truefrom the frontend integration test workflow since V2 is now the default.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bin/gravitino.sh.template | Default to V2 war; honor GRAVITINO_USE_WEB_V1=true to fall back to V1. |
| build.gradle.kts | Switch deploy/embedded test war path selection to V2-by-default. |
| conf/gravitino-env.sh.template | Replace V2 opt-in comment/var with V1 opt-out (GRAVITINO_USE_WEB_V1). |
| .github/workflows/frontend-integration-test.yml | Remove GRAVITINO_USE_WEB_V2=true prefixes; rely on new default. |
| README.md | Document V2 as default and how to switch to legacy V1. |
| docs/webui-v2.md | Update Web V2 docs to describe the inverted flag/default. |
| web-v2/web/README.md | Add note explaining V2-default behavior and GRAVITINO_USE_WEB_V1 opt-out. |
| web/web/src/app/rootLayout/Layout.js | Update V1 banner copy to reference GRAVITINO_USE_WEB_V1=false. |
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
N/A
Fix: #11335
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually