Skip to content

test: make hive testdeleteschema deterministic (schema lifecycle) #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jack-LuoHongyi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: make hive testdeleteschema deterministic (schema lifecycle) #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions gora-hive/src/test/java/org/apache/gora/hive/store/TestHiveStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@
import org.apache.gora.examples.generated.WebPage;
import org.apache.gora.hive.GoraHiveTestDriver;
import org.apache.gora.persistency.impl.BeanFactoryImpl;
import org.apache.gora.store.DataStore;
import org.apache.gora.store.DataStoreTestBase;
import org.apache.gora.store.DataStoreTestUtil;
import org.apache.gora.util.GoraException;
import org.apache.gora.util.StringUtils;
import org.junit.Ignore;
import org.junit.Test;
import java.util.concurrent.TimeUnit;

/**
* HiveStore Tests extending {@link DataStoreTestBase} which run the base JUnit test suite for
Expand Down Expand Up @@ -152,6 +154,37 @@ public void testUpdate() throws Exception {
//Hive test server doesn't support deleting and updating entries
}

@Override
public void testDeleteSchema() throws Exception {
log.info("test method: testDeleteSchema");
final long waitMs = TimeUnit.SECONDS.toMillis(10);

webPageStore.createSchema();
awaitSchemaState(webPageStore, true, waitMs);

webPageStore.deleteSchema();
awaitSchemaState(webPageStore, false, waitMs);

webPageStore.createSchema();
awaitSchemaState(webPageStore, true, waitMs);
}

private void awaitSchemaState(DataStore<String, WebPage> store, boolean shouldExist, long timeoutMs) throws Exception {
long deadline = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(timeoutMs);
while (System.nanoTime() < deadline) {
if (shouldExist) {
store.createSchema();
} else {
store.deleteSchema();
}
boolean exists = store.schemaExists();
if (exists == shouldExist) return;
Thread.sleep(100);
}
String msg = shouldExist ? "schema not visible after create" : "schema still exists after delete";
assertTrue(msg, shouldExist == store.schemaExists());
}

@Ignore("Hive datastore doesn't support recursive records")
@Override
public void testGetRecursive() throws Exception {
Expand Down
Loading