[VL] Implement push partial agg thru expand rule#12052
Draft
zhouyuan wants to merge 1 commit intoapache:mainfrom
Draft
[VL] Implement push partial agg thru expand rule#12052zhouyuan wants to merge 1 commit intoapache:mainfrom
zhouyuan wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
May 8, 2026
| * (grouping_keys, gid) ExpandExec (augmented) <-- pass-through + null-fill HashAggregateExec | ||
| * (partial) <-- pre-agg on original rows, no gid Project BroadcastHashJoin ... | ||
| */ | ||
| object PushPartialAggThroughExpand extends Rule[SparkPlan] with Logging { |
Contributor
There was a problem hiding this comment.
This seems useful for vanilla Spark as well? Should we consider merging it into the upstream Spark?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch adds a optimization rule which can push partial agg thru expand
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?