[VL][Delta] Add UniForm Iceberg support wiring#12047
Open
malinjawi wants to merge 2 commits intoapache:mainfrom
Open
[VL][Delta] Add UniForm Iceberg support wiring#12047malinjawi wants to merge 2 commits intoapache:mainfrom
malinjawi wants to merge 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
983fba6 to
5cc239b
Compare
|
Run Gluten Clickhouse CI on x86 |
5cc239b to
434c553
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds the first Velox Delta write-side support slice for UniForm Iceberg.
The change keeps Delta as the source of truth for the transaction and UniForm metadata-generation flow. Gluten now passes Delta column-mapping field IDs through the Velox native Parquet writer path when
IcebergCompatV2is enabled, so newly written Delta files can satisfy the Parquet field-id part of the UniForm Iceberg contract.This PR also:
delta-icebergto the Velox Delta build/test profileWriterOptions.parquetFieldIdsdocs/get-started/VeloxDelta.mdfromNot testedtoPartialCurrent scope / behavior:
IcebergCompatV2How was this patch tested?
Build / validation:
./build/mvn -Pbackends-velox,delta,spark-3.5 -pl backends-velox -am -DskipTests test-compileninja -j 6 glutenninja -j 6 libvelox.dylibgit diff --checkFocused local validation:
org.apache.spark.sql.delta.DeltaUniFormIcebergSuitewith-Pbackends-velox,delta,iceberg,spark-3.5org.apache.spark.sql.delta.DeltaUniFormIcebergSuitewith-Pbackends-velox,delta,spark-3.5to verify clean cancellation without Iceberg test classesorg.apache.spark.sql.delta.DeltaInsertIntoSQLNameColumnMappingSuiteFunctional validation:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: IBM BOB
issue: #12039
Follow-up work
This PR intentionally keeps the scope limited to the supported Delta write and Iceberg readback path. Reasonable follow-ups are:
REORG TABLE ... APPLY (UPGRADE UNIFORM(...))