[GLUTEN-8232][VL] Enable dynamic openssl lib in vcpkg packaging#11444
Draft
zhouyuan wants to merge 7 commits into
Draft
[GLUTEN-8232][VL] Enable dynamic openssl lib in vcpkg packaging#11444zhouyuan wants to merge 7 commits into
zhouyuan wants to merge 7 commits into
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_openssl_dynamic
branch
from
ce8f244 to
b55532a
Compare
zhouyuan
changed the title
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_openssl_dynamic
branch
from
9febdcd to
5079457
Compare
philo-he
reviewed
Jan 20, 2026
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Two comments. Please check if they make sense. Thanks.
| run: | | ||
| docker pull apache/gluten:vcpkg-centos-7 | ||
| docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-7 bash -c " | ||
| docker pull apache/gluten:vcpkg-centos-9 |
Member
There was a problem hiding this comment.
Suggest setting container field with centos 9 image, which is a standard way. I assume it's compatible with GHA checkout.
| endif() | ||
|
|
||
| if(PORT STREQUAL "openssl") | ||
| set(VCPKG_LIBRARY_LINKAGE dynamic) |
Member
There was a problem hiding this comment.
Can we use dynamic link only when FIPS is enabled?
My understanding is that FIPS is not a requirement for many users. Then, the current static link for openssl may be good for them.
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_openssl_dynamic
branch
from
aabd20e to
2f47e7d
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch enabled dynamic openssl to include FIPS feature in vcpkg build
How was this patch tested?
pass GHA
Related issue: #8232