chore(java): Update Spotless and Checkstyle to allow building with JDK25#3476
Merged
chaokunyang merged 1 commit intoapache:mainfrom Mar 14, 2026
Merged
Conversation
stevenschlansker
force-pushed
the
checkstyle-jdk25
branch
from
47d33cd to
29817e7
Compare
stevenschlansker
changed the title
stevenschlansker
force-pushed
the
checkstyle-jdk25
branch
from
29817e7 to
d69035a
Compare
| <configuration> | ||
| <configLocation>${fory.java.rootdir}/checkstyle.xml</configLocation> | ||
| <suppressionsLocation>${fory.java.rootdir}/checkstyle-suppressions.xml</suppressionsLocation> | ||
| <encoding>UTF-8</encoding> |
Contributor
Author
There was a problem hiding this comment.
Warning: Parameter 'encoding' is unknown for plugin 'maven-checkstyle-plugin:3.6.0:check (default-cli)'
Contributor
Author
There was a problem hiding this comment.
(the default is source encoding, so this should be okay I think?)
| value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/> | ||
| </module> | ||
| <module name="JavadocMethod"> | ||
| <property name="scope" value="public"/> |
Contributor
Author
There was a problem hiding this comment.
cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation
stevenschlansker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Spotless fails when run in JDK25:
What does this PR do?
Updates build plugins to newer versions with JDK25 support