[Bug] Avoid altering lake catalog for tables that never enabled datalake#3302
Open
MaheshS08 wants to merge 3 commits into
Open
[Bug] Avoid altering lake catalog for tables that never enabled datalake#3302MaheshS08 wants to merge 3 commits into
MaheshS08 wants to merge 3 commits into
Conversation
Contributor
Author
|
@luoyuxia , could you please review this PR? |
2 tasks
Contributor
But ci fails |
Contributor
|
Hi @MaheshS08 Looks like the CI failure is from Spotless formatting. You may have missed running Also, please go through the contributing guidelines once most of these checks are covered there and it helps avoid CI failures |
Contributor
Author
|
@Prajwal-banakar thanks for the head's up. I have re-pushed to the branch with necessary changes. @luoyuxia , please have a look at this PR, now the checks have been passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3297
The
preAlterTablePropertiesmethod was callinglakeCatalog.alterTable()for every table alter operation whenever a lake catalog was configured at the
cluster level, even for plain Fluss tables that never had
table.datalake.enabledset. This resulted in unnecessary calls to the lake catalog, which would throw
TableNotExistException(silently swallowed) for tables unknown to the lake catalog.Brief change log
MetadataManager#preAlterTableProperties, tightened the guard conditionfrom
if (lakeCatalog != null)to also check that the current table descriptorcontains the
table.datalake.enabledkey (regardless of its value).lakeCatalog.alterTable()is only called for tables that haveever opted into datalake, while preserving the existing sync behavior for
tables that were previously lake-enabled and later disabled.
Tests
API and Format
No API or storage format changes. This is a behavioral fix in the coordinator's
metadata management logic only.
Documentation
No new feature introduced. No documentation changes required.