[rust] Add end-to-end ROW type#544
Open
fresh-borzoni wants to merge 2 commits intoapache:mainfrom
Open
Conversation
- Add `Datum::Row(Box<GenericRow>)` variant with `as_row()` accessor - Add `get_row()` to `InternalRow` trait with default error impl - Implement `GenericRow::get_row()` and `CompactedRow::get_row()` delegation - Implement `ColumnarRow::get_row()` with Arrow StructArray extraction + OnceLock caching - Add `InnerValueWriter::Row(RowType)` and write path via nested CompactedRowWriter - Add `DataType::Row` arm in `CompactedRowDeserializer` for eager nested decode - Add `InnerFieldGetter::Row` and hook up FieldGetter/ValueWriter pipeline - Handle `Datum::Row` in `resolve_row_types` (C++ bindings) - Add round-trip tests: simple nesting, deep nesting, nullable fields, ROW as primary key Wire format matches Java: varint-length-prefixed blob of a complete CompactedRow.
fresh-borzoni
force-pushed
the
row-type-revive
branch
from
d750eb2 to
41289fc
Compare
Member
Author
fresh-borzoni
force-pushed
the
row-type-revive
branch
3 times, most recently
from
54c8908 to
4ad3a28
Compare
fresh-borzoni
force-pushed
the
row-type-revive
branch
from
4ad3a28 to
fb693b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues work from #442 (which went stale).
Original implementation by @hemanthsavasere and this PR rebases on current main, addresses review feedback and adds the follow-ups listed below.
Closes #388
Closes #442
Original work
Datum::Row,InternalRow::get_row, CompactedRow ROW deserializerNestedRowWriter, ROW arm in compacted key encoderAdded in this revival
field_idmachinery (server requires unique ids across nested ROW —matches Java's
ReassignFieldId)ARRAY<ROW>supportVec<OnceLock>allocation killedleft followup #543 to address performance with nested structures, as this is PR is big enough and the gap comes from pre-existing code