Skip to content

[FLINK-39385][table] TIMESTAMPDIFF fails for TIME #27880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snuyanzin merged 1 commit into from
Apr 2, 2026
+5 −1
Merged

[FLINK-39385][table] TIMESTAMPDIFF fails for TIME #27880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...nner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import org.apache.flink.table.types.logical.LogicalTypeRoot._
import org.apache.flink.table.types.logical.utils.LogicalTypeChecks
import org.apache.flink.table.types.logical.utils.LogicalTypeChecks.{getFieldTypes, getPrecision, getScale}
import org.apache.flink.table.types.logical.utils.LogicalTypeMerging.findCommonType
import org.apache.flink.table.utils.DateTimeUtils.MILLIS_PER_DAY
import org.apache.flink.table.utils.DateTimeUtils.{MILLIS_PER_DAY, MILLIS_PER_SECOND}
import org.apache.flink.table.utils.EncodingUtils
import org.apache.flink.types.ColumnList
import org.apache.flink.util.Preconditions.checkArgument
Expand Down Expand Up @@ -271,6 +271,8 @@ object ScalarOperatorGens {
case (DATE, TIMESTAMP_WITHOUT_TIME_ZONE) =>
val rightTerm = s"$rr.getMillisecond()"
s"($ll * ${MILLIS_PER_DAY}L) $op $rightTerm"
case (TIME_WITHOUT_TIME_ZONE, TIME_WITHOUT_TIME_ZONE) =>
s"($ll $op $rr)"
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions ...planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,6 +1327,8 @@ class TemporalTypesTest extends ExpressionTestBase {
testSqlApi("TIMESTAMPDIFF(MONTH, TIME '00:00:00', TIMESTAMP '2021-02-04 12:00:00')", "613")
testSqlApi("TIMESTAMPDIFF(MONTH, DATE '2021-01-04', TIME '00:00:00')", "-612")
testSqlApi("TIMESTAMPDIFF(MONTH, TIME '00:00:00', DATE '2021-02-04')", "613")
testSqlApi("TIMESTAMPDIFF(SECOND, TIME'10:10:10', TIME'11:11:11')", "3661");
testSqlApi("TIMESTAMPDIFF(MINUTE, TIME'08:00:00', TIME'11:11:00')", "191");
}

@Test
Expand Down