[hotfix][docs/test] Migrate the assertj assertion lines to link-calling.#27879
Open
RocMarshal wants to merge 1 commit intoapache:masterfrom
Open
[hotfix][docs/test] Migrate the assertj assertion lines to link-calling.#27879RocMarshal wants to merge 1 commit intoapache:masterfrom
RocMarshal wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
snuyanzin
reviewed
Apr 1, 2026
| @@ -78,15 +78,14 @@ void testExcludeFromDocumentation(@TempDir Path tmpDir) throws Exception { | |||
| file); | |||
| final String actual = new String(Files.readAllBytes(file), StandardCharsets.UTF_8); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| final String actual = new String(Files.readAllBytes(file), StandardCharsets.UTF_8); | |
| final String actual = Files.readString(file); |
since jdk11 is minimum now
and other same occurrences in this file
snuyanzin
reviewed
Apr 1, 2026
Comment on lines
+82
to
+85
| .contains("/test/empty1") | ||
| .contains("This is a testing REST API.") | ||
| .contains("/test/empty2") | ||
| .contains("This is another testing REST API.") |
Contributor
There was a problem hiding this comment.
Suggested change
| .contains("/test/empty1") | |
| .contains("This is a testing REST API.") | |
| .contains("/test/empty2") | |
| .contains("This is another testing REST API.") | |
| .containsAnyOf("/test/empty1", | |
| "This is a testing REST API.", | |
| "/test/empty2", | |
| "This is another testing REST API.") |
snuyanzin
reviewed
Apr 1, 2026
Comment on lines
+86
to
90
| .doesNotContain("/test/exclude1") | ||
| .doesNotContain("This REST API should not appear in the generated documentation.") | ||
| .doesNotContain("/test/exclude2") | ||
| .doesNotContain( | ||
| "This REST API should also not appear in the generated documentation."); |
Contributor
There was a problem hiding this comment.
Suggested change
| .doesNotContain("/test/exclude1") | |
| .doesNotContain("This REST API should not appear in the generated documentation.") | |
| .doesNotContain("/test/exclude2") | |
| .doesNotContain( | |
| "This REST API should also not appear in the generated documentation."); | |
| .doesNotContain("/test/exclude1", | |
| "This REST API should not appear in the generated documentation.", | |
| "/test/exclude2", | |
| "This REST API should also not appear in the generated documentation."); |
snuyanzin
reviewed
Apr 1, 2026
Comment on lines
+58
to
66
| .containsSequence("/test/empty1") | ||
| .containsSequence("This is a testing REST API.") | ||
| .containsSequence("/test/empty2") | ||
| .containsSequence("This is another testing REST API.") | ||
| .doesNotContain("/test/exclude1") | ||
| .doesNotContain("This REST API should not appear in the generated documentation.") | ||
| .doesNotContain("/test/exclude2") | ||
| .doesNotContain( | ||
| "This REST API should also not appear in the generated documentation."); |
snuyanzin
reviewed
Apr 1, 2026
| @@ -54,15 +54,14 @@ void testExcludeFromDocumentation() throws Exception { | |||
| file.toPath()); | |||
| String actual = FileUtils.readFile(file, StandardCharsets.UTF_8); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[hotfix][docs/test] Migrate the assertj assertion lines to link-calling.
Brief change log
[hotfix][docs/test] Migrate the assertj assertion lines to link-calling.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation