[FLINK-34644][runtime] Fix race condition in RestServerEndpoint shutdown#27878
Open
balassai wants to merge 1 commit intoapache:release-1.20from
Open
[FLINK-34644][runtime] Fix race condition in RestServerEndpoint shutdown#27878balassai wants to merge 1 commit intoapache:release-1.20from
balassai wants to merge 1 commit intoapache:release-1.20from
Conversation
…own (apache#27708) * [FLINK-34644][runtime] Fix race condition in RestServerEndpoint shutdown causing flaky test Change thenAccept to thenCompose in AbstractRestHandler.respondToRequest() so that the returned future only completes after the HTTP response is fully flushed to the network. Previously, the future returned by HandlerUtils.sendResponse() was silently discarded, allowing InFlightRequestTracker.deregisterRequest() to fire before the response write completed. Under load this let shutDownInternal() tear down the Netty event loops while response bytes were still in flight, causing ConnectionClosedException on the client side. * [FLINK-34644][sql-gateway] Apply same thenAccept to thenCompose fix in AbstractSqlGatewayRestHandler Apply the same fix as AbstractRestHandler: change thenAccept to thenCompose in respondToRequest() so the returned future only completes after the HTTP response is fully flushed. This prevents the same race condition where in-flight request deregistration could fire before the response write completes.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #27708 to release-1.20