[FLINK-34022][core] Fix ArithmeticException in TimeUtils.formatWithHighestUnit for large Duration values#27877
Open
balassai wants to merge 1 commit intoapache:release-1.20from
Open
Conversation
…nit for large Duration values Duration.toNanos() throws ArithmeticException when the nanosecond value overflows a long (e.g. Duration.ofMillis(Long.MAX_VALUE)). Fix by converting the internal computation to BigInteger throughout formatWithHighestUnit, toNanos, and getHighestIntegerUnit, matching the fix already applied to main via FLINK-35820.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport of FLINK-35820 to release-1.20.
TimeUtils.formatWithHighestUnit()internally calledDuration.toNanos()which throws anArithmeticExceptionwhen the nanosecond value overflows along(e.g.Duration.ofMillis(Long.MAX_VALUE)).Brief change log
longtoBigIntegerto avoid arithmetic overflowTimeUtilsPrettyPrintingTestcoveringLong.MAX_VALUEms and values beyondlongrangeVerifying this change
TimeUtilsPrettyPrintingTest