[FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled#27874
Open
och5351 wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled#27874och5351 wants to merge 1 commit intoapache:masterfrom
och5351 wants to merge 1 commit intoapache:masterfrom
Conversation
…r streaming jobs with the adaptive scheduler enabled
Collaborator
RocMarshal
requested changes
Apr 1, 2026
Contributor
RocMarshal
left a comment
RocMarshal
left a comment
There was a problem hiding this comment.
Hi, @och5351 Thank you for your hard work.
LGTM on the whole, just a few of comments.
PTAL in your free time :)
Comment on lines
+21
to
+48
| export interface RescalesHistory { | ||
| rescaleUuid: string; | ||
| resourceRequirementsUuid: string; | ||
| rescaleAttemptId: number; | ||
| vertices: object; | ||
| slots: object; | ||
| schedulerStates: unknown[]; | ||
| startTimestampInMillis: number; | ||
| endTimestampInMillis: number; | ||
| terminalState: string; | ||
| triggerCause: string; | ||
| terminatedReason: string; | ||
| expand?: boolean; | ||
| } | ||
|
|
||
| export interface RescalesDetailHistory { | ||
| rescaleUuid: string; | ||
| resourceRequirementsUuid: string; | ||
| rescaleAttemptId: number; | ||
| vertices: { [vertexId: string]: RescaleVertex }; | ||
| slots: { [slotSharingGroupId: string]: RescaleSlot }; | ||
| schedulerStates: SchedulerState[]; | ||
| startTimestampInMillis: number; | ||
| endTimestampInMillis: number; | ||
| terminalState: string; | ||
| triggerCause: string; | ||
| terminatedReason: string; | ||
| } |
Contributor
There was a problem hiding this comment.
- What about renaming it to
JobRescaleDetails(keep the same name as backend REST part) - What about merging the two interface into one for reusing( The corresponding class in backend is one class.)?
export interface JobRescaleDetails {
rescaleUuid: string;
resourceRequirementsUuid: string;
rescaleAttemptId: number;
vertices?: { [vertexId: string]: VertexParallelismRescaleInfo };
slots?: { [slotSharingGroupId: string]: SlotSharingGroupRescaleInfo };
schedulerStates?: SchedulerState[];
startTimestampInMillis: number;
endTimestampInMillis: number;
terminalState: string;
triggerCause: string;
terminatedReason: string;
}
| terminatedReason: string; | ||
| } | ||
|
|
||
| export interface RescaleVertex { |
Contributor
There was a problem hiding this comment.
->VertexParallelismRescaleInfo
| postRescaleParallelism: number; | ||
| } | ||
|
|
||
| export interface RescaleSlot { |
Contributor
There was a problem hiding this comment.
-> SlotSharingGroupRescaleInfo
| acquiredResourceProfile: ResourceProfile; | ||
| } | ||
|
|
||
| export interface ResourceProfile { |
Comment on lines
+89
to
+93
| {{ truncateUuid(history.rescaleUuid) }} | ||
| </td> | ||
| <td>{{ history.rescaleAttemptId }}</td> | ||
| <td nz-tooltip [nzTooltipTitle]="history.resourceRequirementsUuid"> | ||
| {{ truncateUuid(history.resourceRequirementsUuid) }} |
Comment on lines
+109
to
+121
| <p> | ||
| Rescale UUID: | ||
| {{ truncateUuid(history.rescaleUuid) }} | ||
| Attempt ID: | ||
| {{ history.rescaleAttemptId }} | ||
| Requirements ID: | ||
| {{ truncateUuid(history.resourceRequirementsUuid) }} | ||
| Trigger Cause: | ||
| {{ history.triggerCause }} | ||
| Terminal State: | ||
| {{ history.terminalState }} | ||
| Terminal Reason: {{ history.terminatedReason }} | ||
| </p> |
Contributor
There was a problem hiding this comment.
The part could reference the implementation of web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
| stringifiedException: string; | ||
| } | ||
|
|
||
| export interface RescalesConfig { |
Contributor
There was a problem hiding this comment.
Suggested change
| export interface RescalesConfig { | |
| export interface JobRescaleConfigInfo { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief change log
Adds the 'Rescales/History' tab and 'HistoryDetail' subpage in relation to [FLINK-38897][Runtime/REST] Introduce /jobs/:jobid/rescales/config endpoint to REST API #27580.
Rescales History Tab
Rescales HistoryDetail page
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation