-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38523] Update Pekko to 1.4.0 #27368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
bb2c38f
35d951e
bb5a288
59457bb
81ceb74
05fde20
d2088ba
b65099b
0a4138e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -418,6 +418,14 @@ under the License. | |
| <version>2.5.1</version> | ||
| <scope>runtime</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-bom</artifactId> | ||
| <version>4.1.100.Final</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
|
Comment on lines
+423
to
+428
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably I missed it during first look can we also bump netty here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this might not have been there when you've had the first look, I'm still running into issues on the Azure CI. We currently use Apache Arrow 13.0.0 which was built against Netty 4.1.96. The newest Apache Arrow version is 18.3.0, that uses Netty 4.1.119. I'll play with this, but we most probably won't be able to use Netty 4.2.x here. |
||
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration was not used before for a long time, I believe since this commit: 30c4bc8#diff-659981ee1b5263cef2478bd413c1e4b5122c9a636ef76bc0d4aafc9633274644
Before this upgrade, Netty disabled hostname verification by default, but since 4.2.x, it's enabled by default, according to the official migration guide.
I've added the necessary code in
SSLUtilsto check for this config option when setting upSSLContext, but I felt like it's a good idea to disable hostname verification by default with this change, as that was the behavior before this PR as well.