[FLINK-38762][runtime] Introduce SingleJobApplication #27362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eemario
force-pushed
the
FLIP549-5
branch
2 times, most recently
from
f9f006f to
933fcc1
Compare
zhuzhurk
reviewed
Dec 26, 2025
| .thenApply(ack -> streamGraph.getJobID()); | ||
| } | ||
|
|
||
| protected CompletableFuture<Acknowledge> internalSubmit( |
|
|
||
| private void runRecoveredJob(final ExecutionPlan recoveredJob) { | ||
| private void runRecoveredJob( | ||
| final ExecutionPlan recoveredJob, final boolean wrapIntoApplication) { |
Contributor
There was a problem hiding this comment.
Could you add some comments to explain the behavior around with regard to wrapIntoApplication?
| executionPlan.getJobID())); | ||
| } | ||
|
|
||
| private Optional<AbstractApplication> getApplicationForJob(ExecutionPlan executionPlan) { |
Contributor
There was a problem hiding this comment.
I guess this method should be used in internalSubmitJob?
| instanceof | ||
| FlinkJobNotFoundException) { | ||
| log.warn( | ||
| "Ignore job {} which may be expired when requesting application {}", |
Contributor
There was a problem hiding this comment.
It's weird that a job is expired in the history while its hosting application is not expired.
| JobManagerJobMetricGroupFactory jobManagerJobMetricGroupFactory, | ||
| FatalErrorHandler fatalErrorHandler, | ||
| Collection<FailureEnricher> failureEnrichers, | ||
| JobStatusListener singleJobApplication, |
Contributor
There was a problem hiding this comment.
singleJobApplication -> jobStatusListener
The handler should simple treat it as a JobStatusListener instead of a SingleJobApplication.
| executionPlan.getApplicationId().map(applications::get); | ||
| if (optionalApplication.isPresent()) { | ||
| AbstractApplication application = optionalApplication.get(); | ||
| if (application instanceof JobStatusListener) { |
Contributor
There was a problem hiding this comment.
I think the clearer logic should be: if an application is a SingleJobApplication, it needs be passed to the jobManager as a JobStatusListener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces SingleJobApplication that is used in session mode to run a single job in an application.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation