[FLINK-38139] Fix consecutive online schema change causes job failure.#4324
Open
beryllw wants to merge 4 commits intoapache:masterfrom
Open
[FLINK-38139] Fix consecutive online schema change causes job failure.#4324beryllw wants to merge 4 commits intoapache:masterfrom
beryllw wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@yuxiqian Could you please help review this PR? |
yuxiqian
reviewed
Mar 19, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Thanks Junbo for the nice work! Just left some minor comments.
...-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java
Outdated
Show resolved
Hide resolved
...-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java
Show resolved
Hide resolved
...nnector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlOscITCase.java
Outdated
Show resolved
Hide resolved
...nnector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlOscITCase.java
Outdated
Show resolved
Hide resolved
beryllw
force-pushed
the
pr-4064-online-schema-change
branch
from
5ef2bc7 to
9775fc0
Compare
yuxiqian
approved these changes
Mar 19, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Looks good to me overall, except one minor comment.
| } | ||
| } | ||
|
|
||
| public static Optional<String> parseOnLineSchemaRenameEvent(SourceRecord record) { |
Member
There was a problem hiding this comment.
Shall we extract OSC event related methods into an individual class, like, OnlineSchemaChangeUtils?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4064 (comment)