[runtime] Fix prune state corner cases around checkpoints#603
Open
joeyutong wants to merge 1 commit intoapache:mainfrom
Open
[runtime] Fix prune state corner cases around checkpoints#603joeyutong wants to merge 1 commit intoapache:mainfrom
joeyutong wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change
ActionExecutionOperatorhad two prune-state corner cases around checkpoints.prune bookkeeping used
messageSequenceNumber, which tracks the latest started sequence, not the latest completed sequence. That means an in-flight sequence could be treated as prune-safe.the operator pruned action state as soon as a run completed. If the job later recovered from an earlier completed checkpoint, replay of the same input could no longer reuse the durable action state that had already been written.
Fix
This change makes pruning checkpoint-safe again.
lastCompletedSequenceNumberkeyed statelastCompletedSequenceNumberinstead ofmessageSequenceNumbernotifyCheckpointCompleteTests
The updated tests cover:
API
No
Documentation
doc-neededdoc-not-neededdoc-included