Skip to content

FINERACT-xxxx: Add equals() and hashCode() to LoanTransaction #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshdhall01 wants to merge 1 commit into
base: develop
Choose a base branch
from
+19 −2
Open

FINERACT-xxxx: Add equals() and hashCode() to LoanTransaction #5855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ...-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.Collection;
import java.util.HashSet;
import java.util.List;
import java.util.Objects;
import java.util.Set;
import java.util.function.Predicate;
import lombok.Getter;
Expand Down Expand Up @@ -1014,8 +1015,24 @@ public void updateAmount(BigDecimal bigDecimal) {
this.amount = bigDecimal;
}

// TODO missing hashCode(), equals(Object obj), but probably OK as long as
// this is never stored in a Collection.
@Override
public boolean equals(final Object obj) {
if (this == obj) {
return true;
}
if (!(obj instanceof LoanTransaction other)) {
return false;
}
if (getId() == null || other.getId() == null) {
return false;
}
return Objects.equals(getId(), other.getId());
}

@Override
public int hashCode() {
return Objects.hash(getId());
}

public void updateTransactionDate(final LocalDate transactionDate) {
this.dateOf = transactionDate;
Expand Down