Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ public ProcessingResultLookup mapRow(final ResultSet rs, @SuppressWarnings("unus
}

public String schema() {
return " select enum_id as id, enum_message_property as status from r_enum_value where enum_name = 'status' "
return " select enum_id as id, enum_value as status from r_enum_value where enum_name = 'status' "
+ " order by enum_id";
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.

-->
<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">

<!--
Seeds the missing 'status' enum values into r_enum_value for command processing results.
These were originally defined in fineract-db/old-schema-files/0002-mifosx-base-reference-data-utf8.sql
but were never carried over to the Liquibase changelog. enum_id values must stay fixed to
match CommandProcessingResultType integer values, as the audit query joins on ev.enum_id = aud.status.
-->
<changeSet author="fineract" id="1">
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="0"/>
<column name="enum_message_property" value="invalid"/>
<column name="enum_value" value="Invalid"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="1"/>
<column name="enum_message_property" value="processed"/>
<column name="enum_value" value="Processed"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="2"/>
<column name="enum_message_property" value="awaiting.approval"/>
<column name="enum_value" value="Awaiting Approval"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="3"/>
<column name="enum_message_property" value="rejected"/>
<column name="enum_value" value="Rejected"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="4"/>
<column name="enum_message_property" value="underProcessing"/>
<column name="enum_value" value="Under Processing"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
<insert tableName="r_enum_value">
<column name="enum_name" value="status"/>
<column name="enum_id" valueNumeric="5"/>
<column name="enum_message_property" value="error"/>
<column name="enum_value" value="Error"/>
<column name="enum_type" valueBoolean="false"/>
</insert>
</changeSet>

</databaseChangeLog>
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,22 @@ public void testAuditSearchTemplate() {
assertNotNull(auditSearchTemplate);
assertEquals(4, auditSearchTemplate.size()); // appUsers, actionNames, entityNames, processingResults
assertTrue(((List) auditSearchTemplate.get("actionNames")).size() > 0);

// verify all command processing status enum values are present and use enum_value (not enum_message_property)
List<LinkedHashMap> processingResults = (List<LinkedHashMap>) auditSearchTemplate.get("processingResults");
assertNotNull(processingResults);
assertEquals(6, processingResults.size());

List<String> statusValues = processingResults.stream()
.map(r -> (String) r.get("processingResult"))
.collect(java.util.stream.Collectors.toList());

assertTrue(statusValues.contains("Invalid"));
assertTrue(statusValues.contains("Processed"));
assertTrue(statusValues.contains("Awaiting Approval"));
assertTrue(statusValues.contains("Rejected"));
assertTrue(statusValues.contains("Under Processing"));
assertTrue(statusValues.contains("Error"));
}

/**
Expand Down
Loading