Skip to content

FINERACT-2575: replace archived Avro Gradle plugin#5736

Open
San-43 wants to merge 1 commit intoapache:developfrom
San-43:FINERACT-2575-change-unmaintained-Avro-schema-generation-plugin
Open

FINERACT-2575: replace archived Avro Gradle plugin#5736
San-43 wants to merge 1 commit intoapache:developfrom
San-43:FINERACT-2575-change-unmaintained-Avro-schema-generation-plugin

Conversation

@San-43
Copy link
Copy Markdown
Contributor

@San-43 San-43 commented Apr 3, 2026

Replaces the archived Avro Gradle plugin with eu.eventloopsoftware.avro-gradle-plugin in fineract-avro-schemas.
The migration keeps the current generation flow unchanged:

  • Preserves schema preprocessing for bigdecimal
  • Keeps the custom Avro templates
  • Keeps the existing buildJavaSdk task contract for downstream modules

I also restored enableDecimalLogicalType = true so decimal fields continue to be generated as BigDecimal instead of ByteBuffer.

Copy link
Copy Markdown
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to better wait for official release from apache first https://issues.apache.org/jira/browse/AVRO-4223 instead of using beta version

id 'com.github.spotbugs' version '6.0.26' apply false
id 'se.thinkcode.cucumber-runner' version '0.0.11' apply false
id "com.github.davidmc24.gradle.plugin.avro-base" version "1.9.1" apply false
id "eu.eventloopsoftware.avro-gradle-plugin" version "0.1.2" apply false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we better hold this one and this plugin is maintained by a single developer. Which is a huge supply chain risk.
As stated by maintainer in ticket https://issues.apache.org/jira/browse/AVRO-4223

A planned release is discussed here under the name of org.apache.avro

If that gets release. I think we should wait for it and use that instead

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see PR apache/avro#3614

@San-43
Copy link
Copy Markdown
Contributor Author

San-43 commented Apr 5, 2026

I think to better wait for official release from apache first https://issues.apache.org/jira/browse/AVRO-4223 instead of using beta version

Thank you very much for your review @Aman-Mittal . I agree we should wait for the official Apache release, and hopefully it won’t take long. I found INFRA-27616, so it looks like the plugin is ready and just waiting to be published as org.apache.avro.

@adamsaghy
Copy link
Copy Markdown
Contributor

I think to better wait for official release from apache first https://issues.apache.org/jira/browse/AVRO-4223 instead of using beta version

Thank you very much for your review @Aman-Mittal . I agree we should wait for the official Apache release, and hopefully it won’t take long. I found INFRA-27616, so it looks like the plugin is ready and just waiting to be published as org.apache.avro.

I am not convinced anyone is working on ot.

Infra ticket is closed with resolution "later".
avro ticket seems abandoned

@Aman-Mittal
Copy link
Copy Markdown
Contributor

I think to better wait for official release from apache first https://issues.apache.org/jira/browse/AVRO-4223 instead of using beta version

Thank you very much for your review @Aman-Mittal . I agree we should wait for the official Apache release, and hopefully it won’t take long. I found INFRA-27616, so it looks like the plugin is ready and just waiting to be published as org.apache.avro.

I am not convinced anyone is working on ot.

Infra ticket is closed with resolution "later". avro ticket seems abandoned

@adamsaghy Pr is currently being review for merge against Apache Avro repo. If it is urgent to upgrade.I think we should add TODO: comment here to use official Apache plugin instead when it gets release. While i still emphasize that we should wait for it as there is also parent ticket https://issues.apache.org/jira/browse/AVRO-3731 in which original maintainer davidmc24 has offered to donated this plugin to ASF which is voted by the avro PMC members.
Or we can open a discussion to dev list too.

@adamsaghy
Copy link
Copy Markdown
Contributor

I think to better wait for official release from apache first https://issues.apache.org/jira/browse/AVRO-4223 instead of using beta version

Thank you very much for your review @Aman-Mittal . I agree we should wait for the official Apache release, and hopefully it won’t take long. I found INFRA-27616, so it looks like the plugin is ready and just waiting to be published as org.apache.avro.

I am not convinced anyone is working on ot.
Infra ticket is closed with resolution "later". avro ticket seems abandoned

@adamsaghy Pr is currently being review for merge against Apache Avro repo. If it is urgent to upgrade.I think we should add TODO: comment here to use official Apache plugin instead when it gets release. While i still emphasize that we should wait for it as there is also parent ticket https://issues.apache.org/jira/browse/AVRO-3731 in which original maintainer davidmc24 has offered to donated this plugin to ASF which is voted by the avro PMC members. Or we can open a discussion to dev list too.

its not urgent to upgrade. i just wanted someone(s) to review the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants