FINERACT-2559: Fix redundant database query during classification retrieval#5724
Open
kalisingh2277 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2559: Fix redundant database query during classification retrieval#5724kalisingh2277 wants to merge 1 commit intoapache:developfrom
kalisingh2277 wants to merge 1 commit intoapache:developfrom
Conversation
…rieval Signed-off-by: Kali <kalisingh2277@gmail.com>
Harshitmehra-270709
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses FINERACT-2559.
In the loan product details read path, the classification mapping flow previously executed an additional repository query (
findAllChargeOffReasonsMappings) whose result was immediately discarded and never used. This created an unnecessary database round trip with no functional benefit, adding to database overhead during loan product details retrieval.Changes
productToGLAccountMappingRepository.findAllChargeOffReasonsMappings(loanProductId, portfolioProductType.getValue())withinProductToGLAccountMappingReadPlatformServiceImpl.fetchClassificationMappings.This is a minor performance optimization that eliminates a redundant database query without making any functional changes to the codebase.