FINERACT-2570: Defer webhook/hook event publication to after transaction commit in batch requests with enclosingTransaction=true#5719
Open
rhopman wants to merge 1 commit intoapache:developfrom
Conversation
…ion commit in batch requests with enclosingTransaction=true
Contributor
Author
|
Looks like the CI is failing because of an infrastructure issue. Can someone take a look and maybe re-run the checks? |
DeathGun44
reviewed
Mar 31, 2026
| long commandId = 1L; | ||
| JsonCommand jsonCommand = Mockito.mock(JsonCommand.class); | ||
| when(jsonCommand.commandId()).thenReturn(commandId); | ||
| when(jsonCommand.json()).thenReturn(null); // publishHookEvent exits early when json is null |
Contributor
There was a problem hiding this comment.
I get the intent here returning null saves us from having to mock a bunch of stuff for publishHookEvent.
But right now, the test doesn't have any assertions; it just passes because nothing breaks. At the very least, we can drop in an assertFalse(TransactionSynchronizationManager.isSynchronizationActive()) to prove no sync was registered.
Also, the test name mentions "PublishedImmediately", but returning null skips publication altogether. Might be worth either renaming the test to fit what's actually happening or adding the mocks to verify the immediate publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a batch request uses enclosingTransaction: true, Fineract fires hook events (webhooks) inside the database transaction, before the batch has fully committed. If a later request in the batch fails, the entire batch is rolled back, but the webhook for the earlier (now rolled-back) request has already been dispatched.
This causes downstream systems that rely on webhooks (e.g. SMS notifications) to act on events that never actually persisted.
Checklist