Skip to content

FINERACT-2571: Migrate NotificationHelper to fineract-client #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lliikkii7722-ops wants to merge 2 commits into
base: develop
Choose a base branch
from
+12 −8
Open

FINERACT-2571: Migrate NotificationHelper to fineract-client #5713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20520a2
FINERACT: Migrate NotificationHelper to fineract-client
Mar 29, 2026
b16dac4
FINERACT-2571: Preserve request headers in NotificationHelper
lliikkii7722-ops Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions ...n-tests/src/test/java/org/apache/fineract/integrationtests/common/NotificationHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,19 @@

import static org.awaitility.Awaitility.await;

import com.google.gson.Gson;
import io.restassured.specification.FilterableRequestSpecification;
import io.restassured.specification.RequestSpecification;
import io.restassured.specification.ResponseSpecification;
import java.time.Duration;
import java.util.HashMap;
import java.util.Map;
import lombok.extern.slf4j.Slf4j;
import org.apache.fineract.client.models.GetNotificationsResponse;
import org.apache.fineract.client.util.JSON;
import org.apache.fineract.client.util.Calls;

@Slf4j
public final class NotificationHelper {

private static final String NOTIFICATION_API_URL = "/fineract-provider/api/v1/notifications?" + Utils.TENANT_IDENTIFIER;
private static final Gson GSON = new JSON().getGson();

private NotificationHelper() {}

// TODO: Rewrite to use fineract-client instead!
Expand All @@ -42,10 +41,15 @@ private NotificationHelper() {}
@Deprecated(forRemoval = true)
public static GetNotificationsResponse getNotifications(final RequestSpecification requestSpec,
final ResponseSpecification responseSpec) {
final String GET_NOTIFICATIONS_URL = NOTIFICATION_API_URL;
log.info("-----------------------------GET NOTIFICATIONS-----------------------------------");
String response = Utils.performServerGet(requestSpec, responseSpec, GET_NOTIFICATIONS_URL);
return GSON.fromJson(response, GetNotificationsResponse.class);

FilterableRequestSpecification filterableRequestSpec = (FilterableRequestSpecification) requestSpec;

Map<String, String> headers = new HashMap<>();
headers.put("Authorization", filterableRequestSpec.getHeaders().getValue("Authorization"));
headers.put("Fineract-Platform-TenantId", filterableRequestSpec.getHeaders().getValue("Fineract-Platform-TenantId"));

return Calls.ok(FineractClientHelper.getFineractClient().notifications.getAllNotifications(null, 1, 0, null, null, headers));
}

// TODO: Rewrite to use fineract-client instead!
Expand Down
Loading