FINERACT-2561: Move organisation currency validation outside loop in saveAllDebitOrCreditEntries#5712
Open
AshharAhmadKhan wants to merge 1 commit intoapache:developfrom
Conversation
…saveAllDebitOrCreditEntries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JIRA: https://issues.apache.org/jira/browse/FINERACT-2561
The
saveAllDebitOrCreditEntries()method was executing the sameorganisation currency validation query inside the per-entry loop, causing
redundant identical database round-trips on every debit/credit line of a
manual journal entry request.
Since
currencyCodedoes not change within a single request, the validationonly needs to run once per method invocation — not once per loop iteration.
This fix moves
organisationCurrencyRepository.findOneWithNotFoundDetection(currencyCode)to before the loop, consistent with the pattern already used in the same class
inside
saveAllDebitOrCreditOpeningBalanceEntries().No logic change — validation still happens, just once instead of N times.