Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
* KIND, either express or implied.
*/
package org.apache.fineract.infrastructure.core.service;

Expand All @@ -34,14 +32,14 @@ void clearContext() {
RequestContextHolder.resetRequestAttributes();
}

// Proper isolation helper
// Helper method for setting request context
private void withRequest(HttpServletRequest request, Runnable testLogic) {
ServletRequestAttributes attributes = new ServletRequestAttributes(request);
try {
RequestContextHolder.setRequestAttributes(attributes);
testLogic.run();
} finally {
RequestContextHolder.resetRequestAttributes(); // critical cleanup
RequestContextHolder.resetRequestAttributes();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Doesnt do anything. Better to revert this file change entirely

}
}

Expand Down Expand Up @@ -86,4 +84,4 @@ void getClientIpConvertsNonStringAttributeUsingToString() {
assertEquals("12345", result);
});
}
}
}
Loading