Skip to content

FINERACT-2491: Refactor SavingsEnumerations to use switch expression#5503

Open
Abdelrahman-358 wants to merge 1 commit intoapache:developfrom
Abdelrahman-358:FINERACT-2491-savings-enumerations-switch-expression
Open

FINERACT-2491: Refactor SavingsEnumerations to use switch expression#5503
Abdelrahman-358 wants to merge 1 commit intoapache:developfrom
Abdelrahman-358:FINERACT-2491-savings-enumerations-switch-expression

Conversation

@Abdelrahman-358
Copy link

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some test classes?

@Abdelrahman-358
Copy link
Author

Could you please add some test classes?

Sure, I'll add the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants