Skip to content

FINERACT-2486: Fix guarantor endpoint returning savingsAccount.id=0 f…#5482

Merged
IOhacker merged 1 commit intoapache:developfrom
symbaglobal:FINERACT-2486-fix-group-savings-guarantor-id
Feb 14, 2026
Merged

FINERACT-2486: Fix guarantor endpoint returning savingsAccount.id=0 f…#5482
IOhacker merged 1 commit intoapache:developfrom
symbaglobal:FINERACT-2486-fix-group-savings-guarantor-id

Conversation

@rhopman
Copy link
Contributor

@rhopman rhopman commented Feb 12, 2026

…or group savings

Description

When retrieving guarantor details via GET /loans/{loanId}/guarantors, the response shows savingsAccount.id = 0 for guarantors backed by group savings accounts, even though the on-hold transactions are correctly recorded with the actual savings account ID.

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@IOhacker IOhacker merged commit 8a61e30 into apache:develop Feb 14, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants