FINERACT-2473: Add available balance to group accounts endpoint#5468
Conversation
Aman-Mittal
left a comment
There was a problem hiding this comment.
Address review comments, and please sign your commit with GPG key
...c/main/java/org/apache/fineract/portfolio/accountdetails/data/SavingsAccountSummaryData.java
Outdated
Show resolved
Hide resolved
|
@rhopman from Adam Monsen's email: There's a new ci action for PRs to check that new commits are signed. All committers already have PGP/GPG keys, so just make sure you're also signing commits. You can add this to your ~/.gitconfig (or equivalent) to do it automatically: [commit] Upload your public key to github to make the verified badges green. More info: FINERACT-2177, PR #5431. Hints: 1) try it locally before pushing. 2) have git run it for you: Create .git/hooks/pre-push with: #!/bin/sh Be sure to make that script executable. |
cbb4c9b to
988260d
Compare
988260d to
87f2264
Compare
|
@rhopman it shows conflicts that must be resolve, but I am unable to display which are the errors. Could you please help us? |
87f2264 to
f30c22a
Compare
Done |
Description
Adds
availableBalancefield to the group accounts endpoint (/groups/{groupId}/accounts), providing visibility into withdrawable funds by distinguishing between total balance and funds on hold.Changes
New Fields Added to Savings Account Summary:
onHoldFunds- Automatic holds from loan guaranteessavingsAmountOnHold- User-initiated/lien holdsavailableBalance- Calculated as:accountBalance - onHoldFunds - savingsAmountOnHoldChecklist
Your assigned reviewer(s) will follow our guidelines for code reviews.