FINERACT-2246: New command processing - document management#5464
Open
vidakovic wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2246: New command processing - document management#5464vidakovic wants to merge 1 commit intoapache:developfrom
vidakovic wants to merge 1 commit intoapache:developfrom
Conversation
d14baf0 to
692ae26
Compare
692ae26 to
298b15e
Compare
163d54b to
06b2e41
Compare
35a3f70 to
23f2f9b
Compare
Contributor
|
@vidakovic seems that there are some conflicts |
Contributor
Author
|
It's actually only one thing left: the bulk import test cases try to retrieve the uploaded documents from the local file system... Which is different when you run your tests locally, in a docker Container or on GitHub actions |
7c78e18 to
7e9c787
Compare
0930ce9 to
68b30cc
Compare
68b30cc to
d684b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Major improvement of document management. Non of the core structures are located outside of "fineract-document" (almost standalone). Major performance improvement due to true streaming of documents (no byte array loading into memory... unless we deal with base64 encoded data). Content is now streamed asynchronously. Document management was actually not using the command concept at all. All document and image operations were not showing up in any audit logs. Everything is now migrated to the new command processing. Applied a technique to remove direct dependencies to staff and client packages.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.