Skip to content

FINERACT-2116: Add validation integration tests for Credit Bureau Configuration APIs#5460

Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2116/credit-bureau-config-validation
Open

FINERACT-2116: Add validation integration tests for Credit Bureau Configuration APIs#5460
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2116/credit-bureau-config-validation

Conversation

@DeathGun44
Copy link
Contributor

Description

This PR adds validation integration tests for Credit Bureau Configuration APIs (FINERACT-2116).

Tests cover:

  • Credit Bureau Configuration: missing/blank/exceeding length for configkey, value, description
  • Organisation Credit Bureau: missing/blank/exceeding length for alias
  • Loan Product Mapping: missing loanProductId, isCreditcheckMandatory, skipCreditcheckInFailure, stalePeriod

Important

Dependency: This PR includes a test for missing loanProductId validation which will fail until #5457 is merged. That PR fixes the NPE that causes a 500 error instead of 400 validation error.

Checklist

@adamsaghy
Copy link
Contributor

@DeathGun44 Please rebase this PR with latest develop branch to fix:

   Test testCreateMapping_MissingLoanProductId_ShouldFail400() FAILED
  
    java.lang.AssertionError: 1 expectation failed.
    Expected status code <400> but was <500>.
        at org.apache.fineract.integrationtests.CreditBureauConfigurationValidationTest.testCreateMapping_MissingLoanProductId_ShouldFail400(CreditBureauConfigurationValidationTest.java:176)
  

@DeathGun44 DeathGun44 force-pushed the FINERACT-2116/credit-bureau-config-validation branch from abfde50 to e7d8544 Compare February 11, 2026 11:52
@DeathGun44
Copy link
Contributor Author

@adamsaghy please re-run the tests ,they should all be green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants