fix(candlestick): support cursor option#21558
Open
diysimon wants to merge 1 commit intoapache:masterfrom
Open
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #21551
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the missing
cursorsupport oncandlestickseries and adds a manual test page for verification.Fixed issues
cursordoes not take effect oncandlestickseriesDetails
Before: What was the problem?
cursoris a supported option on some series types, but it did not work oncandlestick.The main reason was that
candlestickview did not forward the cursor option to zrender elements:itemModel.getShallow('cursor')series.cursorAs a result, hovering candlestick elements still showed the default cursor.
After: How does it behave after the fixing?
After this change:
series.cursorworks oncandlestickin normal modedata[i].cursoralso works in normal modeseries.cursorworks oncandlestickin large modeThe fix is kept minimal by only wiring the existing cursor option through
CandlestickViewand adding a manual test page:test/candlestick-cursor.htmlThe test page includes:
candlestick-shexampleDocument Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/candlestick-cursor.htmlMerging options
Other information
Local verification:
eslinttsc --noEmittest/candlestick-cursor.html