Skip to content

fix: axisLabel.height should work without backgroundColor (#21504) #21505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SakshamSinghal20 wants to merge 2 commits into
base: master
Choose a base branch
from
+389 −0
Open

fix: axisLabel.height should work without backgroundColor (#21504) #21505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7194cc
fixed
SakshamSinghal20 Jan 30, 2026
15befdc
test: add axis-label-height-without-bg case
SakshamSinghal20 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/label/labelStyle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,11 @@ function setTokenTextStyle<TNuance extends TextCommonOptionNuanceBase>(
textStyle.borderColor = inheritColor;
}
}
// If height or width is set but no backgroundColor, set transparent background
// to ensure the box constraints are applied
if ((textStyle.height != null || textStyle.width != null) && textStyle.backgroundColor == null) {
textStyle.backgroundColor = 'transparent';
}
Comment on lines +685 to +689
Copy link
Member

@plainheart plainheart Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is the right way to fix the issue. As I mentioned earlier #21504 (comment), this behavior is likely intentional by design, but it did not account for cases where the text has explicit width, height, or padding. In such situations, the text background box should still be drawn, even when no background color is specified.
I would suggest either implementing the fix at the underlying ZRender, or simply not fixing this "bug" at all, since there is already a simple workaround to avoid the problem.

}

export function getFont(
Expand Down
384 changes: 384 additions & 0 deletions test/axis-label-height-without-bg.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.