Fix Zookeeper startup wait logic in StartZookeeperWindowsProcessor#16086
Open
SURYAS1306 wants to merge 1 commit intoapache:3.3from
Open
Fix Zookeeper startup wait logic in StartZookeeperWindowsProcessor#16086SURYAS1306 wants to merge 1 commit intoapache:3.3from
SURYAS1306 wants to merge 1 commit intoapache:3.3from
Conversation
…rtZookeeperWindowsProcessor
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16086 +/- ##
============================================
- Coverage 60.80% 60.79% -0.02%
- Complexity 11750 11762 +12
============================================
Files 1953 1953
Lines 89121 89121
Branches 13443 13443
============================================
- Hits 54192 54180 -12
- Misses 29369 29377 +8
- Partials 5560 5564 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR! I've taken a look at the logic, and it seems to solve the 'ugly sleep' problem I reported in #16085 by using a proactive Curator check. Since I'm still getting familiar with the project's internal standards, could @zrlw, @AlbumenJ , @heliang666s or any other maintainer please take a quick look to ensure the Curator configuration (timeouts/retry policy) aligns with the best practices? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16085
What is the purpose of the change?
The Windows Zookeeper startup logic currently relies on a fixed sleep:
This is unreliable because Zookeeper startup time varies depending on machine
performance and environment. As a result, tests may randomly fail when the
server is not fully ready after the fixed delay.
This PR replaces the fixed delay with an active readiness check using
CuratorFramework.blockUntilConnected(). The processor now waits until the
Zookeeper instance is actually reachable before continuing.
This makes the test startup deterministic and removes flaky behavior.
Brief changelog
Verifying this change
dubbo-test-checkcompilesChecklist