perf: batch reset invalid stream offsets in stream supervisor#19431
Open
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Open
perf: batch reset invalid stream offsets in stream supervisor#19431jtuglu1 wants to merge 1 commit intoapache:masterfrom
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Conversation
594147e to
51a32eb
Compare
51a32eb to
657e28d
Compare
jtuglu1
commented
May 8, 2026
| // Fetch metadata offsets once and collect all stale partitions across all groups before committing | ||
| // any state changes. New TaskGroups are staged locally and only written to activelyReadingTaskGroups | ||
| // if no reset is required, keeping state consistent: either all new groups are committed or none are. | ||
| final Map<PartitionIdType, SequenceOffsetType> metadataOffsets = getOffsetsFromMetadataStorage(); |
Contributor
Author
There was a problem hiding this comment.
LMK what you think about this – I think this shouldn't impact task groups without invalid offsets as currently they'd just be added to the activelyReadingTaskGroups then be delayed in processing (see few lines down) since generateStartingSequencesForPartitionGroup would just throw an exception (and force a new runInternal()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
I've noticed that recent Druid can be extremely slow to recover from a lagging supervisor (where offsets are invalid and
tuningConfig.resetOffsetAutomatically=true). I have observed the following issue occurs:runInternal(), which can take O(XXs) depending on the supervisor run loop configuration. Since these partitions are evaluated serially, if multiple partitions are invalid offsets, this means we keep looping for every invalid offset for every partition for every taskGroup, leading to many minutes of downtime. This issue is exacerbated when ingesting from large Kafka topics with many partitions.Solution
For each taskGroup, identify + reset all invalid partition offsets in one go. Once we have established the set of invalid offsets, perform an internal reset, then throw the exception. This reduces the time-to-recovery of a fatally-lagged supervisor from N
runInternal()calls to 1runInternal()call, where N is the # of invalid partition offsets.Release note
Batch reset invalid stream offsets in stream supervisor to speed up stream supervisor recovery.
This PR has: